support async_cmd_discard()#8
Merged
Merged
Conversation
wokron
force-pushed
the
support-cmd-discard
branch
from
223fe1c to
35b9339
Compare
There was a problem hiding this comment.
Pull request overview
This pull request adds support for the async_cmd_discard() operation, which wraps the io_uring_prep_cmd_discard function from liburing 2.8+. This allows async discard operations on block devices.
Changes:
- Added
async_cmd_discard()function in the async operations API - Implemented
BlkDevicehelper class for creating loop devices in tests - Added comprehensive test coverage with both basic and fixed fd test cases
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| include/condy/async_operations.hpp | Added async_cmd_discard() function with proper version guard (>= 2.8) following the same pattern as similar operations like async_ftruncate |
| tests/test_async_operations.cpp | Added BlkDevice helper class for test setup and two test cases (basic and fixed fd) that validate the new async_cmd_discard operation |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wokron
force-pushed
the
support-cmd-discard
branch
from
35b9339 to
1bba898
Compare
wokron
force-pushed
the
support-cmd-discard
branch
from
1bba898 to
20b4c8a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.